refactor(ast): introduce #[estree(ts_alias)] attr and use it on Elision#8939
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 7, 2025
Conversation
github-actions
bot
added
A-ast
This was referenced Feb 6, 2025
Merged
Member
Author
CodSpeed Performance ReportMerging #8939 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…ision` (#8939) Introduce `#[estree(ts_alias = "...")]` attribute to tell Typescript generator to substitute another type in the place of this one. Use it on `Elision`, to make its TS type `null`. This allows removing other customizing attributes from other types - the codegen does more of the work.
graphite-app
bot
force-pushed
the
02-06-refactor_ast_shorten_ts_type_definitions_for_enums
branch
from
8b48391 to
66f0afb
Compare
graphite-app
bot
force-pushed
the
02-06-refactor_ast_introduce_estree_ts_alias_attr_and_use_it_on_elision_
branch
from
b62cec2 to
640db88
Compare
Base automatically changed from
02-06-refactor_ast_shorten_ts_type_definitions_for_enums
to
main
February 7, 2025 03:10
graphite-app
bot
deleted the
02-06-refactor_ast_introduce_estree_ts_alias_attr_and_use_it_on_elision_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
#[estree(ts_alias = "...")]attribute to tell Typescript generator to substitute another type in the place of this one.Use it on
Elision, to make its TS typenull. This allows removing other customizing attributes from other types - the codegen does more of the work.